[PATCH rdma-core 1/3] debian: Guard udevadm call again

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



lintian complains with udevadm-called-without-guard:

udevadm can exist but be non-functional (such as inside a chroot) and
thus can result in package installation or upgrade failure if the call
fails.

Please guard the return code of the call via wrapping it in a suitable
if construct or by appending || true.

Refer to https://bugs.debian.org/890224 and the udevadm(8) manual page
for details.

Signed-off-by: Benjamin Drung <benjamin.drung@xxxxxxxxxxxxxxxx>
---
 debian/rdma-core.postinst | 6 +++---
 debian/srptools.postinst  | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/debian/rdma-core.postinst b/debian/rdma-core.postinst
index a76368a4..6486f62e 100644
--- a/debian/rdma-core.postinst
+++ b/debian/rdma-core.postinst
@@ -6,7 +6,7 @@ set -e
 if [ "$1" = "configure" ]; then
     # we ship udev rules, so trigger an update. This has to be done after
     # DEBHELPER restarts systemd to get our new service files loaded.
-    udevadm trigger --subsystem-match=infiniband --action=change
-    udevadm trigger --subsystem-match=net --action=change
-    udevadm trigger --subsystem-match=infiniband_mad --action=change
+    udevadm trigger --subsystem-match=infiniband --action=change || true
+    udevadm trigger --subsystem-match=net --action=change || true
+    udevadm trigger --subsystem-match=infiniband_mad --action=change || true
 fi
diff --git a/debian/srptools.postinst b/debian/srptools.postinst
index c69a3ad1..398534db 100644
--- a/debian/srptools.postinst
+++ b/debian/srptools.postinst
@@ -6,5 +6,5 @@ set -e
 if [ "$1" = "configure" ]; then
     # we ship udev rules, so trigger an update. This has to be done after
     # DEBHELPER restarts systemd to get our new service files loaded.
-    udevadm trigger --subsystem-match=infiniband_mad --action=change
+    udevadm trigger --subsystem-match=infiniband_mad --action=change || true
 fi
-- 
2.14.1

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux