Re: [PATCH] RDMA: Do not used __packed in uapi headers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Feb 07, 2018 at 04:45:51PM -0700, Jason Gunthorpe wrote:
> __packed is not available in linux/types.h, so we cannot use it in
> the uapi headers.
> 
> The construction struct ABC {} __packed; may still compile even if
> __packed is not defined, however it simply creates a variable called
> __packed, and doesn't set the alignment.
> 
> All these uses of packed are on structs that already have aligned
> members.
> 
> While use in hfi may indicate the struct itself is unaligned,
> the use in ocrdma is on a UHW struct which should never be unaligned,
> so just delete it there.
> 
> Signed-off-by: Jason Gunthorpe <jgg@xxxxxxxxxxxx>
>  include/uapi/rdma/hfi/hfi1_user.h | 6 +++---
>  include/uapi/rdma/ocrdma-abi.h    | 4 ++--
>  2 files changed, 5 insertions(+), 5 deletions(-)

applied to -next

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux