Re: [PATCHv2 1/1] IB/rxe: remove unnecessary skb_clone

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > >   	}
> > > -	skb_copy = skb_clone(skb, GFP_ATOMIC);
> > > -	if (skb_copy)
> > > -		rxe_add_ref(qp); /* for the new SKB */
> > Are you sure we don't need this?
> From my stress tests and performance tests, it will get better performance
> to remove skb_clone.

My concern is only with the above ref count.

> And there is no memory leak.  The whole soft RoCE can work well.
> So I think removing this function is a good choice.
> 
> Zhu Yanjun
> > 
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux