Re: [PATCH for-next 1/3] RDMA/hns: Fix a bug with modifying mac address

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



在 2018/2/6 23:53, Jason Gunthorpe 写道:
> On Tue, Feb 06, 2018 at 08:34:17PM +0800, Lijun Ou wrote:
>> When modifying mac address, it will trigger hns_roce_del_gid
>> function and can't delete the default gid matched the index
>> because the attribute of gid is null.
>>
>> Signed-off-by: Lijun Ou <oulijun@xxxxxxxxxx>
>>  drivers/infiniband/hw/hns/hns_roce_main.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/infiniband/hw/hns/hns_roce_main.c b/drivers/infiniband/hw/hns/hns_roce_main.c
>> index eb9a69f..6f39afb 100644
>> +++ b/drivers/infiniband/hw/hns/hns_roce_main.c
>> @@ -100,6 +100,7 @@ static int hns_roce_del_gid(struct ib_device *device, u8 port_num,
>>  			    unsigned int index, void **context)
>>  {
>>  	struct hns_roce_dev *hr_dev = to_hr_dev(device);
>> +	const struct ib_gid_attr zattr;
> 
> That is uninited stack memory, need a = {}
> 
> Jason
> 
> 
Thanks, I have sent the patch V2.

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux