Re: [PATCH rfc 2/5] irq-am: add some debugfs exposure on tuning state

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Sagi,

I love your patch! Yet something to improve:

[auto build test ERROR on v4.15]
[also build test ERROR on next-20180206]
[cannot apply to linus/master rdma/for-next]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Sagi-Grimberg/irq-am-Introduce-library-implementing-generic-adaptive-moderation/20180206-224501
config: i386-randconfig-s0-201805 (attached as .config)
compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   lib/irq-am.c:17:8: error: type defaults to 'int' in declaration of 'DEFINE_IDA' [-Werror=implicit-int]
    static DEFINE_IDA(am_ida);
           ^~~~~~~~~~
   lib/irq-am.c:17:1: warning: parameter names (without types) in function declaration
    static DEFINE_IDA(am_ida);
    ^~~~~~
   lib/irq-am.c: In function 'irq_am_cleanup':
>> lib/irq-am.c:262:2: error: implicit declaration of function 'ida_simple_remove' [-Werror=implicit-function-declaration]
     ida_simple_remove(&am_ida, am->id);
     ^~~~~~~~~~~~~~~~~
   lib/irq-am.c:262:21: error: 'am_ida' undeclared (first use in this function)
     ida_simple_remove(&am_ida, am->id);
                        ^~~~~~
   lib/irq-am.c:262:21: note: each undeclared identifier is reported only once for each function it appears in
   lib/irq-am.c: In function 'irq_am_init':
>> lib/irq-am.c:276:11: error: implicit declaration of function 'ida_simple_get' [-Werror=implicit-function-declaration]
     am->id = ida_simple_get(&am_ida, 0, 0, GFP_KERNEL);
              ^~~~~~~~~~~~~~
   lib/irq-am.c:276:27: error: 'am_ida' undeclared (first use in this function)
     am->id = ida_simple_get(&am_ida, 0, 0, GFP_KERNEL);
                              ^~~~~~
   lib/irq-am.c: At top level:
   lib/irq-am.c:17:8: warning: 'DEFINE_IDA' declared 'static' but never defined [-Wunused-function]
    static DEFINE_IDA(am_ida);
           ^~~~~~~~~~
   cc1: some warnings being treated as errors

vim +/ida_simple_remove +262 lib/irq-am.c

   257	
   258	void irq_am_cleanup(struct irq_am *am)
   259	{
   260		flush_work(&am->work);
   261		irq_am_deregister_debugfs(am);
 > 262		ida_simple_remove(&am_ida, am->id);
   263	}
   264	EXPORT_SYMBOL_GPL(irq_am_cleanup);
   265	
   266	void irq_am_init(struct irq_am *am, unsigned int nr_events,
   267		unsigned short nr_levels, unsigned short start_level, irq_am_fn *fn)
   268	{
   269		memset(am, 0, sizeof(*am));
   270		am->state = IRQ_AM_START_MEASURING;
   271		am->tune_state = IRQ_AM_GOING_UP;
   272		am->nr_levels = nr_levels;
   273		am->nr_events = nr_events;
   274		am->curr_level = start_level;
   275		am->program = fn;
 > 276		am->id = ida_simple_get(&am_ida, 0, 0, GFP_KERNEL);
   277		WARN_ON(am->id < 0);
   278		INIT_WORK(&am->work, irq_am_program_moderation_work);
   279		if (irq_am_register_debugfs(am))
   280			pr_warn("irq-am %d failed to register debugfs\n", am->id);
   281	}
   282	EXPORT_SYMBOL_GPL(irq_am_init);
   283	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux