On Wed, 2018-01-24 at 15:06 +0000, Bart Van Assche wrote:
> On Wed, 2018-01-24 at 14:43 +0200, Yuval Shaia wrote:
> > To be compatible with other modules/drivers, change return code checks
> > from "if (rc != 0)" to "if (rc)".
>
> Sorry but I think this is a completely pointless change. All the code that is
> touched by this patch works fine, conforms to all appropriate coding style
> guides and is easy to read. So why change it?
>
> Bart.
Hi Yuval,
Since about 1/3 of the LOC in this is in srp/srpt, and the maintainer
objects and thinks the patch is unnecessary, I'm inclined to drop this
unless you want to make an argument for why it should go on in.
--
Doug Ledford <dledford@xxxxxxxxxx>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDDAttachment:
signature.asc
Description: This is a digitally signed message part
