On Thu, Feb 01, 2018 at 03:08:11PM -0700, Jason Gunthorpe wrote: > On Thu, Feb 01, 2018 at 07:02:33PM +0530, Aishwarya Pant wrote: > > Add documentation for core and hardware specific infiniband interfaces. > > The descriptions have been collected from git commit logs, reading > > through code and data sheets. Some drivers have incomplete doc and are > > annotated with the comment '[to be documented]'. > > > > Signed-off-by: Aishwarya Pant <aishpant@xxxxxxxxx> > > Documentation/ABI/testing/sysfs-class-infiniband | 755 +++++++++++++++++++++++ > > 1 file changed, 755 insertions(+) > > Wow this looks really great > > Should this patch delete some of the old documentation? Yeah, I should do that because the documentation in Documentation/infiniband/sysfs.txt is out of date. > > > diff --git a/Documentation/ABI/testing/sysfs-class-infiniband b/Documentation/ABI/testing/sysfs-class-infiniband > > Lots, maybe even all of of this is considered stable.. Okay, I guess it should belong to the stable directory then. > > > +sysfs interface for Broadcom NetXtreme-E RoCE driver > > +---------------------------------------------------- > > + > > +What: /sys/class/infiniband/bnxt_reX/fw_rev > > +What: /sys/class/infiniband/bnxt_reX/hw_rev > > +What: /sys/class/infiniband/bnxt_reX/hca_type > > These are actually common to all drivers > > /sys/class/infiniband/XXX/fw_rev, etc Would make sense to define these at one place- hw_rev, hca_type, board_id are common to a lot of the drivers. Aishwarya > > Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html