RE: [PATCH rdma-core] iwpmd: fix double mutex unlock

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> >
> > pthread_mutex_unlock() is used twice and this patch fixes it.
> >
> > Fixes: be3fbf85b ("iwpmd: use ccan list.h for pending_messages")
> > Signed-off-by: Potnuri Bharat Teja <bharat@xxxxxxxxxxx>
> > ---
> >  iwpmd/iwarp_pm_helper.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/iwpmd/iwarp_pm_helper.c b/iwpmd/iwarp_pm_helper.c
> > index bebc151f329b..b8c230189d50 100644
> > --- a/iwpmd/iwarp_pm_helper.c
> > +++ b/iwpmd/iwarp_pm_helper.c
> > @@ -578,7 +578,6 @@ int add_iwpm_pending_msg(iwpm_send_msg
> > *send_msg)
> >
> >  	pthread_mutex_lock(&pending_msg_mutex);
> >  	list_add(&pending_messages, &pending_msg->entry);
> > - 	pthread_mutex_unlock(&pending_msg_mutex);
> >  	pthread_mutex_unlock(&pending_msg_mutex);
> >  	/* signal the thread that a new message has been posted */
> >  	pthread_cond_signal(&cond_pending_msg);
> 
> Good catch.
> 
> Reviewed-by: Steve Wise <swise@xxxxxxxxxxxxxxxxxxxxx>

And this definitely needs to flow to stable.

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux