On Thu, Jan 18, 2018 at 10:11:15AM +0200, Leon Romanovsky wrote: > Changelog: > v0 -> v1: > * Returned zeros when device is not yet bound to cm_id. > * Reordered patches. > * Moved checks of being not-NULL for the sgid, dgid into rdma_read_gids() > and made that function ugly like hell. > > >From Parav: > > Currently there are few issues with rdma_addr_get_dgid() and > rdma_addr_get_sgid() APIs. They are described below. > > 1. rdma_addr_get_dgid() returns MAC address for RoCE connections. > 2. rdma_addr_get_sgid() returns SGID based on IPv4 address regardless > of connection of AF_INET or AF_INET6 type; resulting into returning > incorrect SGID. > 3. rdma_addr_get_sgid() returns SGID based on the first IP address of > the netdevice interface. netdevice can have multiple IP adresses. When > connection is established by non first IP address, this results into > returning incorrect SGID. > 4. rdma_addr_get_sgid() is not actually used in connection establishment > APIs such as rdma_resolve_addr(), rdma_resolve_route(), rdma_accept() > for RoCE transport. > RoCE specific rdma cm APIs have used ip2gid() API to derive SGID. > > Additionally, ULP module such as net/rds accesses some of the internal > data structures of the rdma_cm_id, such as rdma_route and rdma_addr > structure which might not be the best way to access GIDs. > > rdma_ucm module provides GIDs to user space via ucma_query_gid() API. > In certain above conditions it returns incorrect GIDs. > > Therefore, this patchset introduces a transport agnostic API for > existing ULP such as rds and rdma_ucm to query GIDs for a given > connection referred by rdma_cm_id. > > Since rdma_addr_get_sgid() is not used for RoCE transport during > connection establishment phase, iboe_addr_get_sgid() is removed. > rdma_addr_get_sgid() is refactored for such simplicity. > > rdma_read_gids() new API is introduced that allows to read the SGID > and/or DGID of the rdma_cm_id for client and server side connections. > > Therefore, this patchset introduces a transport agnostic API for > existing ULP such as rds and rdma_ucm to query GIDs for a given > connection referred by rdma_cm_id. > > Since RoCE support was incrementally added, there is no specific commit > id that can be qualified as breaking rdma_addr_get_sgid() API. > rdma_addr_get_dgid() was written initially without RoCE transport in > consideration. When RoCE support was added incrementally, this API > remained broken. Applied to for-next thanks Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
