On Tue, Jan 16, 2018 at 05:03:56PM -0600, Steve Wise wrote: > > > From: Leon Romanovsky <leonro@xxxxxxxxxxxx> > > > > Update all callers to provide owner name through QP attribute > > structure and connect create_qp with helper which supports > > resource tracking. > > > > Reviewed-by: Mark Bloch <markb@xxxxxxxxxxxx> > > Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxxxx> > > Reviewed-by: Steve Wise <swise@xxxxxxxxxxxxxxxxxxxxx> > > --- > > drivers/infiniband/core/cma.c | 1 + > > drivers/infiniband/core/mad.c | 1 + > > drivers/infiniband/core/uverbs_cmd.c | 3 +-- > > drivers/infiniband/core/verbs.c | 4 ++-- > > drivers/infiniband/hw/mlx4/mad.c | 1 + > > drivers/infiniband/hw/mlx4/qp.c | 1 + > > drivers/infiniband/hw/mlx5/gsi.c | 2 ++ > > drivers/infiniband/ulp/ipoib/ipoib_cm.c | 4 +++- > > drivers/infiniband/ulp/ipoib/ipoib_verbs.c | 1 + > > drivers/infiniband/ulp/srp/ib_srp.c | 1 + > > drivers/infiniband/ulp/srpt/ib_srpt.c | 1 + > > net/smc/smc_ib.c | 1 + > > 12 files changed, 16 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c > > index 30d1c32a816f..3810716ea65e 100644 > > --- a/drivers/infiniband/core/cma.c > > +++ b/drivers/infiniband/core/cma.c > > @@ -858,6 +858,7 @@ int rdma_create_qp(struct rdma_cm_id *id, struct > > ib_pd *pd, > > return -EINVAL; > > > > qp_init_attr->port_num = id->port_num; > > + strncpy(qp_init_attr->comm, "rdma-cm", TASK_COMM_LEN); > > > I think the above strncpy should be done only if the caller of > rdma_create_qp() didn't fill in qp_init_attr->comm. IE if the caller ULP > fills it out, we want to see it. Otherwise all kernel ULPs end up being > "rdma-cm"... Thanks Steve, This patch won't be needed in next revision, I found a way to use compiler to generate the kernel name. > > Stevo >
Attachment:
signature.asc
Description: PGP signature
