On Tue, Jan 16, 2018 at 09:35:42PM +0000, Bart Van Assche wrote:
> On Mon, 2018-01-15 at 17:12 +0200, Leon Romanovsky wrote:
> > --- a/include/rdma/ib_verbs.h
> > +++ b/include/rdma/ib_verbs.h
> > @@ -1141,6 +1141,12 @@ struct ib_qp_init_attr {
> > u8 port_num;
> > struct ib_rwq_ind_table *rwq_ind_tbl;
> > u32 source_qpn;
> > +
> > + /*
> > + * Name of entity which created this QP, empty string means that
> > + * it will be taken automatically from task_struct.
> > + */
> > + char comm[TASK_COMM_LEN];
> > };
>
> Why is comm[] an array? For queue pairs created from user space, are there any
> queue pairs that can live longer than the task that created them? If not, does
> that mean that it is safe to change comm into a const char pointer?
As I wrote in cover letter, this code will be refactored and moved to PD once
Steve's implementation of CMA resource tracking will be accepted in upstream.
>
> Additionally, please use the kernel-doc syntax to document structure members.
Kernel-doc checker doesn't work with patches and ib_verbs.h full of
kernel-doc warning.
>
> Thanks,
>
> Bart.
Attachment:
signature.asc
Description: PGP signature
