On 01/16/2018 03:57 AM, Martin K. Petersen wrote: > > Sagi, > >> Isn't a bit backwards that each individual driver needs this knob to >> modify the block layer behavior? I think a better approach would be to >> get rid of the drivers modparams and simply add a block sysfs knob >> that would take the knob guard if supported... > > Originally the IP checksum thing was an optimization for a single > device. But others adopted it as well so it grew from being a driver > tweak to a common feature. > > I don't have a problem adding a way to toggle it at the block layer. But > it would have to be an additional knob. We can't nuke the module > parameters without breaking a ton of stuff... > ? So what now? Do we need to keep the parameter? If so we really should be re-enable it; ATM it's just a no-op leading the user to believe something has actually happened. I'm fine with adding a knob in sysfs to enable things, but I'm a bit puzzled now what will happen with this parameter... Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@xxxxxxxx +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
