Re: [PATCH v2 net 0/2] IB/ipoib: ip link support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Denis Drozdov <denisd@xxxxxxxxxxxx>
Date: Tue,  9 Jan 2018 23:42:45 +0200

> IP link was broken due to the changes in IPoIB for the rdma_netdev
> support after commit cd565b4b51e5
> ("IB/IPoIB: Support acceleration options callbacks").
> 
> This patchset restores IPoIB pkey creation and removal using rtnetlink.
> The first patch introduces changes in the rtnetlink code in order to allow
> IPOIB allocate and free the netdevice.
> 
> The second patch establishes appropriate rtnetlink callbacks for IPoIB
> device and restores IPoIB netlink support
> 
> Changes since v1:
> - Fixed double free_netdev calls in ops->free_link in netdev_run_todo 
> - Removed priv_size from ipoib_link_ops as not required anymore.

Please fix your control flow so that the existing netlink op can do
the right thing.

We're not going to add a whole new set of netdev ops every time a subsystem
has a weird control flow issue that no other device type has.  Please fix
this inside of the IB stack, thank you.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux