Re: [PATCH rdma-next v3 2/7] RDMA/core: Add helper function to create named QPs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2018-01-11 at 17:31 +0200, Leon Romanovsky wrote:
> --- a/include/rdma/ib_verbs.h
> +++ b/include/rdma/ib_verbs.h
> @@ -1141,6 +1141,12 @@ struct ib_qp_init_attr {
>         u8                      port_num;
>         struct ib_rwq_ind_table *rwq_ind_tbl;
>         u32                     source_qpn;
> +
> +       /*
> +        * Name of entity which created this QP, empty string means that
> +        * it will be taken automatically from task_struct.
> +        */
> +       char comm[TASK_COMM_LEN];
>  };

Why is "comm" a char array instead of a const char pointer or dynamically
allocated memory (kstrdup())? Can we get rid of the strncpy() calls in code
that fills in this data structure?

Thanks,

Bart.

��.n��������+%������w��{.n�����{���fk��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux