On Wed, Jan 03, 2018 at 10:05:56AM -0500, Dennis Dalessandro wrote: > On 12/20/2017 3:25 AM, Leon Romanovsky wrote: > > On Mon, Dec 18, 2017 at 07:56:23PM -0800, Dennis Dalessandro wrote: > > > The call to strchr in our counter initialization does not check the return > > > value before attempting to use the pointer. In theory this should not > > > happen given the way the code is structured but do the smart thing and > > > check the value anyway to harden the code. > > > > The smartest way is to get rid of the whole "\n"<->"\0" logic and > > copy/paste mlx5 implementation which does the same thing but statically > > and much safer than here. > > > > Thanks > > > > Not sure I'd agree. Is there something unsafe about the code here? The hole > is plugged. Changing the entire implementation for a copy/paste job doesn't > seem like a good thing to me. The names are static and can't be changed. IMHO, the whole implementation is overkill. Thanks > > -Denny
Attachment:
signature.asc
Description: PGP signature
