Le 19/12/2017 à 20:09, Honggang LI a écrit :
> From: Honggang Li <honli@xxxxxxxxxx>
>
> fd3005f0cd34 moves the signal handler setup from ibsrpdm path. So,
> default signal handler will be used when the main pthread send signal
> SIGINT to pthread async_ev_thread. ibsrpdm will exit with non-zero
> exit code as default signal handler killed it. ibsrpdm should return
> with exit code zero, if no error emerged.
>
> We should not create async_ev_thread for ibsrpdm.
>
> Fixes: fd3005f0cd34 ("srp_daemon: Move the setup of the wakeup_pipe after openlog")
> Reviewed-by: Bart Van Assche <bart.vanassche@xxxxxxx>
> Signed-off-by: Honggang Li <honli@xxxxxxxxxx>
> ---
> srp_daemon/srp_daemon.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/srp_daemon/srp_daemon.c b/srp_daemon/srp_daemon.c
> index cec36db2..4012a7db 100644
> --- a/srp_daemon/srp_daemon.c
> +++ b/srp_daemon/srp_daemon.c
> @@ -1945,12 +1945,12 @@ static struct resources *alloc_res(void)
> run_thread_get_trap_notices, &res->res);
> if (ret)
> goto err;
> - }
>
> - ret = pthread_create(&res->res.async_ev_thread, NULL,
> - run_thread_listen_to_events, &res->res);
> - if (ret)
> - goto err;
> + ret = pthread_create(&res->res.async_ev_thread, NULL,
> + run_thread_listen_to_events, &res->res);
> + if (ret)
> + goto err;
> + }
>
> if (config->retry_timeout && !config->once) {
> ret = pthread_create(&res->res.reconnect_thread, NULL,
Reviewed-by: Nicolas Morey-Chaisemartin <nmoreychaisemartin@xxxxxxx>
Note: I will backport this to stable-v1[56] branches once its in master
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
