Re: [PATCH v3 for-next 2/2] RDMA/hns: Fix alignment problem of the doorbell

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 2017/12/29 14:48, Leon Romanovsky wrote:
> On Thu, Dec 28, 2017 at 10:18:03PM +0800, Yixian Liu wrote:
>> The array defined for doorbell is not guaranteed to be 64 bit
>> aligned while we write it to the hardware with 64 bit
>> alignment required.
>>
>> This patch fixes this problem by defining a union for doorbell
>> to make sure it 64 bit alignment.
>>
>> v2 -> v3:
>> 1. delete the unnecessary assignment for doorbell64.
>>
>> v2:
>> 1. Consider with Leon's comments, make sure it is 64 bit
>>    alignment by assigning the expected value to the u64
>>    member of the union type, i.e., assign doorbell array
>>    to doorbell64.
> 
> Please put changelog after "---", so it won't be visible in git log.
> See this patch as an example:
> https://lkml.org/lkml/2017/8/18/785
> 
> Thanks
> 

Okay, I will, Thanks!

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux