On Thu, Dec 28, 2017 at 07:10:31PM +0200, Mark Bloch wrote: > Well, it's not only that, moving the init srcu to the INIT stage > will also make me wrap it around with CONFIG_INFINIBAND_ON_DEMAND_PAGING > which I really don't like seeing in .c files, but we are already doing that > so .... :) Don't micro-optimize so much. Who cares if the few struct members are allocated when !CONFIG_INFINIBAND_ON_DEMAND_PAGING ? Always allocate the SRCU and always initialize it. Maybe even get rid of CONFIG_INFINIBAND_ON_DEMAND_PAGING ? Never understood why we had it in the first place. > If you feel that strongly about it, let me know and I'll change that, > as well as the comment you had about the const in a different patch > and we'll send v1 with the fixes. The function call back thing is really not nice, so I would be happy to see it go away. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
