On Thu, Dec 28, 2017 at 12:02 AM, Jason Gunthorpe <jgg@xxxxxxxxxxxx> wrote: > On Wed, Dec 27, 2017 at 11:16:09PM +0200, Or Gerlitz wrote: >> you added these two flags in the ABI file, but you never use them in downstream >> MLX5_QP_FLAG_TYPE_DCT >> MLX5_QP_FLAG_TYPE_DCI >> patches, something must be wrong here even according to your design > Hm? they are used here: > > + if (ucmd->flags & MLX5_QP_FLAG_TYPE_DCI) > + init_attr->qp_type = MLX5_IB_QPT_DCI; > + else > + init_attr->qp_type = MLX5_IB_QPT_DCT; > > Which is a bad ABI design, check flags explicitly never use else. Maybe, but when I said that in downstream it is assumed user-space knows that for mlx5 DCI/DCT equals IB_QPT_RESERVED3/4 I was wrong, it is derived from the flags. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
