> From: linux-rdma-owner@xxxxxxxxxxxxxxx [mailto:linux-rdma- > owner@xxxxxxxxxxxxxxx] On Behalf Of Jason Gunthorpe > Sent: Wednesday, December 27, 2017 8:58 AM > To: Saleem, Shiraz <shiraz.saleem@xxxxxxxxx> > Cc: dledford@xxxxxxxxxx; linux-rdma@xxxxxxxxxxxxxxx; e1000- > rdma@xxxxxxxxxxxxxxxxxxxxx > Subject: Re: [PATCH rdma-next 0/9] i40iw updates for 4.16 > > On Sat, Dec 23, 2017 at 10:27:08AM -0600, Shiraz Saleem wrote: > > On Fri, Dec 22, 2017 at 04:36:50PM -0700, Jason Gunthorpe wrote: > > > On Fri, Dec 22, 2017 at 09:46:53AM -0600, Shiraz Saleem wrote: > > > > Hi Doug/Jason, > > > > > > > > This patch set includes bug fixes, code refactoring, a new netdev > > > > event notifier and misc. improvements. Please consider it for 4.16. > > > > > > I took this from the v0 series and manually fixed the const myself. > > > > > > I also fixed the checkpatch long line warnings, so please watch out > > > for things like that. > > > > > We try to keep our line length < 100 in general. > > Are we enforcing the 80 char line length limit? > > It is the kernel style, and the goal is to have all code follow the major tenants > of it. > > Linus has come out in the past against > 80 lines as a metric of too much > complexity. > > Jason Many years ago when someone made a stink about nes driver having long lines, Linus got involved in that discussion. He was not in the camp of strictly adhering to the 80 column rule. May be he changed his stance since then. Jason, can you reference an email from Linus so I can update my mental notes on proper kernel development process? Thanks Chien -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
