On Sun, Dec 24, 2017 at 11:53:16PM +0200, Or Gerlitz wrote:
> On Sun, Dec 24, 2017 at 2:57 PM, Leon Romanovsky <leon@xxxxxxxxxx> wrote:
> > From: Daniel Jurgens <danielj@xxxxxxxxxxxx>
> >
> > There are two potential problems with the existing implementation.
> >
> > 1. Enable and disable can race after the atomic operations,
>
> s/,/./
>
> > 2. If a command fails the refcount is left in an inconsistent state.
> >
> > Introduce a lock and perform error checking.
> >
> > Fixes: a6f7d2aff623 ("net/mlx5: Add support for multiple RoCE enable")
>
> Dan, please send this to net as a fix
>
Thanks Or for the suggestion, but we will proceed with our initial plan
and continue to submit this as part of our original dual-port-roce
series.
Thanks
> > Signed-off-by: Daniel Jurgens <danielj@xxxxxxxxxxxx>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Attachment:
signature.asc
Description: PGP signature
