Re: [PATCH for-next] iw_cxgb4: Change error/warn prints to pr_debug

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Dec 19, 2017 at 04:32:54PM -0600, Steve Wise wrote:

> > > In general, I like module names in log statements, but we just
> > > need to do it the right way to avoid the pr_debug issue...
> > 
> > Seems like a bigger problem than for linux-rdma?
> > 
> 
> If redefining pr_fmt is actually the preferred way to add module names, then
> I think pr_debug() might need
> to be fixed.
> 
> > Shouldn't many of these prints be using dev_* stuff and be prefixed
> > with their device name?
> 
> Yea, that makes sense.

Okay, I've dropped this patch.

The two changes to pr_debug should probably become dev_dbg, and
resend?

Deal with the 'what should pr_fmt be' question someplace else :)

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux