RE: [PATCH for-next 01/11] IB/hfi1: Destroy link_wq workqueue after free_irq()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> -----Original Message-----
> From: linux-rdma-owner@xxxxxxxxxxxxxxx [mailto:linux-rdma-
> owner@xxxxxxxxxxxxxxx] On Behalf Of Jason Gunthorpe
> Sent: Wednesday, December 20, 2017 4:11 PM
> To: Ruhl, Michael J <michael.j.ruhl@xxxxxxxxx>
> Cc: Dalessandro, Dennis <dennis.dalessandro@xxxxxxxxx>;
> dledford@xxxxxxxxxx; linux-rdma@xxxxxxxxxxxxxxx; Patel, Jay P
> <jay.p.patel@xxxxxxxxx>; Sanchez, Sebastian <sebastian.sanchez@xxxxxxxxx>
> Subject: Re: [PATCH for-next 01/11] IB/hfi1: Destroy link_wq workqueue after
> free_irq()
> 
> On Wed, Dec 20, 2017 at 09:01:17PM +0000, Ruhl, Michael J wrote:
> 
> > Note: reverting the PCI API patch will not make the crash addressed in:
> >
> > IB/hfi1: Destroy link_wq workqueue after free_irq()
> >
> > issue go away, but will make it more difficult for the issue to occur.
> 
> It is up to you.
> 
> Device removal races should be fixed, but it is often unlikely they
> would impact any user.
> 
> So, abstractly, reverting a racy situation to another racy situation
> doesn't seem like a worthwhile win to me.
> 
> But I do not want to merge this patch which is just making the race
> harder to detect with our debug tools for finding racing..

Ok.  Will work toward getting the race condition addressed more completely.

Mike

 
> Jason
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux