Hi Tomer, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Tomer-Tayar/qed-Utilize-FW-8-33-1-0/20171221-180506 config: xtensa-allmodconfig (attached as .config) compiler: xtensa-linux-gcc (GCC) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=xtensa All warnings (new ones prefixed by >>): In file included from include/linux/printk.h:7:0, from include/linux/kernel.h:14, from include/asm-generic/bug.h:18, from ./arch/xtensa/include/generated/asm/bug.h:1, from include/linux/bug.h:5, from include/linux/io.h:23, from drivers/net//ethernet/qlogic/qed/qed_hw.c:34: drivers/net//ethernet/qlogic/qed/qed_hw.c: In function 'qed_dmae_sanity': >> include/linux/kern_levels.h:5:18: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 6 has type 'dma_addr_t {aka unsigned int}' [-Wformat=] #define KERN_SOH "\001" /* ASCII Start Of Header */ ^ include/linux/kern_levels.h:13:21: note: in expansion of macro 'KERN_SOH' #define KERN_NOTICE KERN_SOH "5" /* normal but significant condition */ ^~~~~~~~ >> include/linux/printk.h:306:9: note: in expansion of macro 'KERN_NOTICE' printk(KERN_NOTICE pr_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~~ >> include/linux/qed/qed_if.h:761:4: note: in expansion of macro 'pr_notice' pr_notice("[%s:%d(%s)]" fmt, \ ^~~~~~~~~ >> drivers/net//ethernet/qlogic/qed/qed_hw.c:866:4: note: in expansion of macro 'DP_NOTICE' DP_NOTICE(p_hwfn, ^~~~~~~~~ drivers/net//ethernet/qlogic/qed/qed_hw.c:867:42: note: format string is defined here "DMAE sanity [%s]: addr={phys 0x%llx, virt %p}, read_val 0x%08x, expected_val 0x%08x\n", ~~~^ %x -- In file included from include/linux/printk.h:7:0, from include/linux/kernel.h:14, from include/asm-generic/bug.h:18, from ./arch/xtensa/include/generated/asm/bug.h:1, from include/linux/bug.h:5, from include/linux/io.h:23, from drivers/net/ethernet/qlogic/qed/qed_hw.c:34: drivers/net/ethernet/qlogic/qed/qed_hw.c: In function 'qed_dmae_sanity': >> include/linux/kern_levels.h:5:18: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 6 has type 'dma_addr_t {aka unsigned int}' [-Wformat=] #define KERN_SOH "\001" /* ASCII Start Of Header */ ^ include/linux/kern_levels.h:13:21: note: in expansion of macro 'KERN_SOH' #define KERN_NOTICE KERN_SOH "5" /* normal but significant condition */ ^~~~~~~~ >> include/linux/printk.h:306:9: note: in expansion of macro 'KERN_NOTICE' printk(KERN_NOTICE pr_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~~ >> include/linux/qed/qed_if.h:761:4: note: in expansion of macro 'pr_notice' pr_notice("[%s:%d(%s)]" fmt, \ ^~~~~~~~~ drivers/net/ethernet/qlogic/qed/qed_hw.c:866:4: note: in expansion of macro 'DP_NOTICE' DP_NOTICE(p_hwfn, ^~~~~~~~~ drivers/net/ethernet/qlogic/qed/qed_hw.c:867:42: note: format string is defined here "DMAE sanity [%s]: addr={phys 0x%llx, virt %p}, read_val 0x%08x, expected_val 0x%08x\n", ~~~^ %x vim +5 include/linux/kern_levels.h 314ba352 Joe Perches 2012-07-30 4 04d2c8c8 Joe Perches 2012-07-30 @5 #define KERN_SOH "\001" /* ASCII Start Of Header */ 04d2c8c8 Joe Perches 2012-07-30 6 #define KERN_SOH_ASCII '\001' 04d2c8c8 Joe Perches 2012-07-30 7 :::::: The code at line 5 was first introduced by commit :::::: 04d2c8c83d0e3ac5f78aeede51babb3236200112 printk: convert the format for KERN_<LEVEL> to a 2 byte pattern :::::: TO: Joe Perches <joe@xxxxxxxxxxx> :::::: CC: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Attachment:
.config.gz
Description: application/gzip
