Re: [PATCHv2 rdma-core 1/2] srp_daemon: handle SM lid change

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Le 15/12/2017 à 12:40, Dennis Dalessandro a écrit :
> On 12/13/2017 7:31 AM, Nicolas Morey-Chaisemartin wrote:
>> When srp_daemon was running and the master SM host changes,
>>   srp_daemon output these errors at every scan:
>> srp_daemon[25394]: No response to inform info registration
>> srp_daemon[25394]: Fail to register to traps, maybe there is no opensm
>>   running on fabric or IB port is down
>>
>> This was introduced by commit 4952e5f Fix a memory leak.
>> A side effect of this patch was that create_ah was only called when the
>>   port lid changes. Which meant register_to_traps used an older, obsolete,
>>   version of sm_lid and failed to connect to it.
>>
>> This patch fixes this behaviour by checking for both local lid changes and
>>   SM lid changes, and calling create_ah on any of these events.
>>
>> Fixes: 4952e5f7 (Fix a memory leak)
>
> Close. You are going to want 12 digits of the SHA, followed by the actual patch subject, the full thing in ("......").
>
> I tried to look at the commit to provide you the actual example but get the following. Make sure the SHA you are using is correct.
>
> $ git show 4952e5f7
> fatal: ambiguous argument '4952e5f7': unknown revision or path not in the working tree.
> Use '--' to separate paths from revisions, like this:
> 'git <command> [<revision>...] -- [<file>...]'

Weird it works for me...
$ git show 4952e5f7
commit 4952e5f7df0c93d6f3972975106c5e06623a301d
Author: Roi Dayan <roid@xxxxxxxxxxxx>
Date:   Thu Mar 21 17:38:11 2013 +0200

    Fix a memory leak

I used this command  to generate the line
$ git  log -n1 --pretty='%h (%s)' 4952e5f7df0c93d6f3972975106c5e06623a301d
4952e5f7 (Fix a memory leak)

Isn't the abbreviated hash supposed to be enough ?

Nicolas
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux