Re: [PATCH for-rc 2/6] RDMA/vmw_pvrdma: Call ib_umem_release on destroy QP path

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Dec 13, 2017 at 10:53:18AM +0200, Yuval Shaia wrote:
> On Fri, Dec 08, 2017 at 11:01:18AM -0800, Bryan Tan wrote:
> > The QP cleanup did not previously call ib_umem_release. Fix this.
> > 
> > Testing Done: ibv_rc_pingpong, rping, perftests.
> > 
> > Fixes: 29c8d9eba550 ("IB: Add vmw_pvrdma driver")
> > Reviewed-by: Adit Ranadive <aditr@xxxxxxxxxx>
> > Reviewed-by: Aditya Sarwade <asarwade@xxxxxxxxxx>
> > Reviewed-by: Jorgen Hansen <jhansen@xxxxxxxxxx>
> > Signed-off-by: Bryan Tan <bryantan@xxxxxxxxxx>
> >  drivers/infiniband/hw/vmw_pvrdma/pvrdma_qp.c | 7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> > diff --git a/drivers/infiniband/hw/vmw_pvrdma/pvrdma_qp.c b/drivers/infiniband/hw/vmw_pvrdma/pvrdma_qp.c
> > index b932b7e..77e7e57 100644
> > +++ b/drivers/infiniband/hw/vmw_pvrdma/pvrdma_qp.c
> > @@ -430,6 +430,13 @@ static void pvrdma_free_qp(struct pvrdma_qp *qp)
> >  	atomic_dec(&qp->refcnt);
> >  	wait_event(qp->wait, !atomic_read(&qp->refcnt));
> >  
> > +	if (!qp->is_kernel) {
> > +		if (qp->rumem)
> 
> IS_ERR_OR_NULL?

How can we get an ERR_PTR in rumem?

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux