> Subject: Re: [PATCH] infiniband: cxgb4: use ktime_get for timestamps > > On Mon, Nov 27, 2017 at 12:44:53PM +0100, Arnd Bergmann wrote: > > The debugfs file prints the difference between host timestamps as a > > seconds/nanoseconds tuple, along with a 64-bit nanoseconds hardware > > timestamp. The host time is read using getnstimeofday() which is > > deprecated because of the y2038 overflow, and it suffers from time jumps > > during settimeofday() and leap seconds. > > > > Converting to ktime_get_ts64() would solve those two, but I'm going > > a little further here by changing to ktime_get() and printing 64-bit > > nanoseconds on both host and hw timestamps. This simplifies the code > > further and makes the output easier to understand. > > > > The format of the debugfs file obviously changes here, but this should > > only be read by humans and not scripts, so I assume it's fine. > > > > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> > > drivers/infiniband/hw/cxgb4/device.c | 34 +++++++++++++++------------------- > > drivers/infiniband/hw/cxgb4/iw_cxgb4.h | 4 ++-- > > drivers/infiniband/hw/cxgb4/qp.c | 6 +++--- > > drivers/infiniband/hw/cxgb4/t4.h | 4 ++-- > > 4 files changed, 22 insertions(+), 26 deletions(-) > > Steve? This changes the format of the debugfs files, so please ack it > if it is Ok.. > I apologize for missing this patch initially. I think this is fine. Acked-by: Steve Wise <swise@xxxxxxxxxxxxxxxxxxxxx> --- This email has been checked for viruses by AVG. http://www.avg.com -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
