On 12/11/2017 6:27 PM, Jason Gunthorpe wrote:
On Mon, Dec 11, 2017 at 06:22:37PM +0200, Yishai Hadas wrote:
On 12/11/2017 5:48 PM, Jason Gunthorpe wrote:
You have added the extra symbols under 'IBVERBS_1.1', but this section
already includes 'IBVERBS_1.0' at part of its definition in the map
file.
Each section only defines the smybols for a single symbol version.
For example 'ibv_destroy_srq' now appears twice in both 1.0 and 1.1.
Correct - ibv_destroy_srq has two symbols and must appear twice in the
map file:
debian/libibverbs1.symbols: ibv_destroy_srq@IBVERBS_1.0 1.1.6
debian/libibverbs1.symbols: ibv_destroy_srq@IBVERBS_1.1 1.1.6
libibverbs/compat-1_0.c:COMPAT_SYMVER_FUNC(ibv_destroy_srq, 1_0, "IBVERBS_1.0",
libibverbs/verbs.c:LATEST_SYMVER_FUNC(ibv_destroy_srq, 1_1, "IBVERBS_1.1",
Why current map file is not well-defined without this patch ?
Every stanza should list every symobl defined for the varsion.
Agree, so this patch comes to improve/fix the original patch [1] from
2007 which introduced 'IBVERBS_1.1' and relied on the linker with the
symvers mechanism, correct ?
[1]
commit fd448acccecab2740b7f35f1fadc64fae6d6b9d3
Author: Roland Dreier <rolandd@xxxxxxxxx>
Date: Mon Jan 29 09:22:18 2007 -0800
Add ABI compatibility for apps linked against libibverbs 1.0
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
