Re: [RFC rdma-core 2/2] srp_daemon: fix CQ handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2017-12-11 at 15:46 +0100, Nicolas Morey-Chaisemartin wrote:
> +tatic int poll_cq_once(struct sync_resources *sync_res, struct ibv_cq *cq,
> +           struct ibv_wc *wc)

Has this patch been tested? I don't think that "tatic" is a valid keyword?

> +		/* Poll CQ once. There may be extra completion that
> +		 * were associated to the previous event */
> +		ret = poll_cq_once(sync_res, cq, wc);
> +		if (ret)
> +			return ret;

How many extra completions can be associated with an event? Is polling once
sufficient? If so, please update the comment ("an" is missing / "were" ->
"was").

Thanks,

Bart.��.n��������+%������w��{.n�����{���fk��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux