On Fri, Dec 01, 2017 at 11:28:06AM -0700, Jason Gunthorpe wrote: > On Fri, Dec 01, 2017 at 07:13:05PM +0100, Benjamin Drung wrote: > > GitHub does not allow to rebase & merge the pull request. Is there any > > reason to not allow the rebase & merge workflow? My commits are atomic > > and the git history is cleaner without the merge commits. > > We have been using the merge workflow. I'm not sure this was every > really discussed which is best or not. > > The git history is simpler with rebase, but merge preserves the 'what > did I test' and preserves the series boundaries, which are also useful things. We are also putting cover letters into the merge commit for documentation purposes. > > Jason
Attachment:
signature.asc
Description: PGP signature
