Hi Don, > -----Original Message----- > From: Don Hiatt [mailto:don.hiatt@xxxxxxxxx] > Sent: Thursday, November 30, 2017 5:40 PM > To: Parav Pandit <parav@xxxxxxxxxxxx>; Dennis Dalessandro > <dennis.dalessandro@xxxxxxxxx>; dledford@xxxxxxxxxx > Cc: linux-rdma@xxxxxxxxxxxxxxx; Ira Weiny <ira.weiny@xxxxxxxxx>; > don.hiatt@xxxxxxxxx > Subject: Re: [PATCH for-next 4/6] IB/CM: Change sgid to IB GID when handling > CM request > > Hi Parav, > > On 11/14/2017 10:50 AM, Parav Pandit wrote: > > Hi Dennis, > > > >> -----Original Message----- > >> From: linux-rdma-owner@xxxxxxxxxxxxxxx [mailto:linux-rdma- > >> owner@xxxxxxxxxxxxxxx] On Behalf Of Dennis Dalessandro > >> Sent: Tuesday, November 14, 2017 6:35 AM > >> To: dledford@xxxxxxxxxx > >> Cc: linux-rdma@xxxxxxxxxxxxxxx; Don Hiatt <don.hiatt@xxxxxxxxx>; Ira > >> Weiny <ira.weiny@xxxxxxxxx> > >> Subject: [PATCH for-next 4/6] IB/CM: Change sgid to IB GID when > >> handling CM request > >> > >> From: Don Hiatt <don.hiatt@xxxxxxxxx> > >> > >> ULPs do not understand OPA GIDs and will reject CM requests if the > >> sgid does not match the local_gid. In order to fix this behavior we > >> convert the OPA GID back to an IB GID. > >> > >> Reviewed-by: Ira Weiny <ira.weiny@xxxxxxxxx> > >> Signed-off-by: Don Hiatt <don.hiatt@xxxxxxxxx> > >> Signed-off-by: Dennis Dalessandro <dennis.dalessandro@xxxxxxxxx> > >> --- > >> drivers/infiniband/core/cm.c | 38 > >> ++++++++++++++++++++++++++++++++++++-- > >> 1 files changed, 36 insertions(+), 2 deletions(-) > >> > >> diff --git a/drivers/infiniband/core/cm.c > >> b/drivers/infiniband/core/cm.c index 5927ee4..f9f6f5e 100644 > >> --- a/drivers/infiniband/core/cm.c > >> +++ b/drivers/infiniband/core/cm.c > >> @@ -1560,6 +1560,37 @@ static u16 cm_get_bth_pkey(struct cm_work > *work) > >> return pkey; > >> } > >> > >> +/** > >> + * Convert OPA SGID to IB SGID > >> + * ULPs (such as IPoIB) do not understand OPA GIDs and will > >> + * reject them as the local_gid will not match the sgid. Therefore, > >> + * change the pathrec's SGID to an IB SGID. > >> + * > > Address and other conversions are in ib_sa.h such as path_conv_opa_to_ib(). > > Do path_conv_opa_to_ib function also need such opa to ib gid conversion? > > Can you place cm_opa_to_ib_sgid function in core/addr.c as it deals with > addresses. > Since this function is only used by the CM (and is only necessary because the > responder is not performing a path record query itself, while the requester has > already done query for us) there is no point in moving it to core/addr.c. Further, > if we do move the function there, we will have to include all the required include > files (pathrec, wc, helper > functions) . Given the limited applicability of this function I prefer to keep it as a > static function as it is. > > While replying back to CM request, is it ok to reply back with IB GID and > reverse conversion not needed or it replies with OPA GID? > > Yes, it is okay to reply back with an IB GID and we do not need the reverse > conversion (effectively they are the same thing as the requester in this case has > already done a pathrec query and does nothing with the reply, and, even if it > does the requester already has the IB gid and will know how to resolve it). Ok. > >> + * @work: Work completion > >> + * @path: Path record > >> + */ > >> +static void cm_opa_to_ib_sgid(struct cm_work *work, > >> + struct sa_path_rec *path) > >> +{ > >> + struct ib_device *dev = work->port->cm_dev->ib_device; > >> + struct ib_gid_attr gid_attr; > >> + u8 port_num = work->port->port_num; > >> + > >> + if (rdma_cap_opa_ah(dev, port_num) && > >> + (ib_is_opa_gid(&path->sgid))) { > >> + union ib_gid sgid; > >> + > >> + if (ib_get_cached_gid(dev, port_num, 0, > > Only gid 0 needs conversion? > Yes, because gid 1 is the OPA gid (per the OPA spec there is only one gid per port > so gid 1 is a caching point for the opa gid). > >> + &sgid, &gid_attr)) { > > Since gid attribute is not used here and applicable to RoCE and its optional, can > you pass NULL and avoid gid_attr? > Will do. Ok. Thanks. ��.n��������+%������w��{.n�����{���fk��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
