On Thu, Nov 16, 2017 at 11:26:04AM +0100, Geert Uytterhoeven wrote:
> With gcc-4.1.2:
>
> drivers/infiniband/core/iwpm_util.c: In function ‘iwpm_send_mapinfo’:
> drivers/infiniband/core/iwpm_util.c:647: warning: ‘ret’ may be used uninitialized in this function
>
> Indeed, if nl_client is not found in any of the scanned has buckets, ret
> will be used uninitialized.
>
> Preinitialize ret to zero to fix this.
Did we come to a conclusion if we should apply this to the RMDA tree? The
patch was marked RFC..
Thanks,
Jason
> Fixes: 30dc5e63d6a5ad24 ("RDMA/core: Add support for iWARP Port Mapper user space service")
> Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> RFC as I have no idea if this can ever happen, and if yes, what's the
> correct behavior to handle it:
> - return 0,
> - return an error code,
> - don't send anything,
> - anything else?
> drivers/infiniband/core/iwpm_util.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/core/iwpm_util.c b/drivers/infiniband/core/iwpm_util.c
> index 3c4faadb8cddd7fd..eb000b540495acd1 100644
> +++ b/drivers/infiniband/core/iwpm_util.c
> @@ -644,7 +644,7 @@ int iwpm_send_mapinfo(u8 nl_client, int iwpm_pid)
> int i = 0, nlmsg_bytes = 0;
> unsigned long flags;
> const char *err_str = "";
> - int ret;
> + int ret = 0;
>
> skb = dev_alloc_skb(NLMSG_GOODSIZE);
> if (!skb) {
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
