On Tue, Nov 21, 2017 at 11:52:17AM -0700, Jason Gunthorpe wrote: > On Tue, Nov 21, 2017 at 12:44:55PM -0600, Henry Orosco wrote: > > The following patches are for the 4.15 kernel. > > These all seem reasonable to me, but again, can you revise the > commit messages so they are acceptable for -rc? > > Linus did not entirely like the commit messages last cycle, so please > lets all try harder to be clear, think of writing your commit messages > in terms of: > > - What is the bug this is fixing? How does the user perceive the bug? > - How did this work before? Did it? > > Many of these messages are just describing what the patch is doing, > without providing context why it is an acceptable change for RC. > > Eg here: > > Use sqsize instead of I40IW_CQP_SW_SQSIZE_2048 to initialize > cqp_requests elements in the for-loop as sqsize is used > to allocate memory for cqp_requests. > > That obviously desribes what the patch does, and I can learn the same > thing by reading the patch, but it does not help anyone understand > what the bug is, how the bug presents to the user, or if it this > patch should be in -rc. > > Jason Sorry, I incorrectly labeled "i40iw: Use sqsize to initialize cqp_requests elements" as a bug fix. This will be deferred to for-next. Additionally, the author is needed to re-evaluate the commit description for following patch "i40iw: Reinitialize add_sd_cnt", but is currently out this week. It will be removed from this patch series and sent later. I will send a new series shortly. > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
