Re: [PATCH 2/8] i40iw: Allocate a sdbuf per CQP WQE

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Nov 20, 2017 at 11:38:00AM -0700, Jason Gunthorpe wrote:
> On Fri, Nov 17, 2017 at 10:46:51AM -0600, Henry Orosco wrote:
> > From: Chien Tin Tung <chien.tin.tung@xxxxxxxxx>
> > 
> > Currently there is only one sdbuf per Control QP(CQP) for programming
> > Segment Descriptor(SD) command thus limiting the number of SD work
> > requests that can be posted to one.  Allocate enough memory for one
> > sdbuf per CQP SQ WQE to allow more than one SD command at a time.
> > When a SD command is posted, it will use the corresponding sdbuf for
> > the WQE.
> 
> It is not clear to me from this description why this would be a rc
> candidate?
> 
> Is this is a bug? or is it adding a feature of increasing the number
> of 'SD work requests'?
>

Its a bug fix as we are reusing the same SD buffer
for all WQEs posted. This is incorrect and will become
a problem if we have multiple simultaneous SD WQEs 
being posted.

Shiraz

 
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux