On Sun, Nov 19, 2017 at 09:21:08PM +0200, Yishai Hadas wrote: > + if (mlx5wq_attr) { > + if (mlx5wq_attr->comp_mask & ~(MLX5DV_WQ_INIT_ATTR_MASK_RESERVED - 1)) > + return -EINVAL; Please no. Check that only the bits this function actually supports are set and get rid of _RESERVED. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html