On Mon, Nov 20, 2017 at 10:33:02AM +0200, Sagi Grimberg wrote: >> I don't really like having a special case just for this slow path >> special case. So if we can avoid it without too much overhead let's >> do it, otherwise we can keep it as-is. > > Saving the state of the request completions adds complication in > general, and we don't even have a request for AENs so it would mean to > keep it under the queue, and we don't really race anything because we > don't have inline data there. So I think its simpler to keep it as is. Ok, let's keep it. But please add a comment explaining why the non-signalled completions are fine for the AER but no one else. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
