Re: [PATCH rdma-next 28/31] IB/cm: Fix avoid sleep while spin lock is held

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Nov 19, 2017 at 08:42:17AM +0000, Amrani, Ram wrote:
> > From: Parav Pandit <parav@xxxxxxxxxxxx>
> >
> > In case of LAP are used for RoCE, it can lead to a problem of sleeping a
> > context while spin lock is held in below flow.
> >
> > cm_lap_handler
> > 	->spin_lock
> > 	-> <..switch_case..>
> > 	-> cm_init_av_for_response
> > 		-> ib_init_ah_from_wc
> > 			-> rdma_addr_find_l2_eth_by_grh
> > 				wait_for_completion()
> >
> > Therefore ah attribute initialization is done for incoming lap requests
> > outside of the lock context.
> >
> > Signed-off-by: Parav Pandit <parav@xxxxxxxxxxxx>
> > Reviewed-by: Daniel Jurgens <danielj@xxxxxxxxxxxx>
> > Signed-off-by: Leon Romanovsky <leon@xxxxxxxxxx>
>
> Should you add a "Fixes:..."?

It wasn't clear to us the origin of the problem hence we decided to avoid Fixes line.

> Pardon my ignorance, but what is LAP?

It should be LAG.

>
> Thanks,
> Ram
>

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux