Re: [PATCH rdma-next 06/31] IB/ipoib: Avoid memory leak if neigh destination was changed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 14, 2017 at 11:51:09PM +0200, Or Gerlitz wrote:
> On Tue, Nov 14, 2017 at 2:51 PM, Leon Romanovsky <leon@xxxxxxxxxx> wrote:
> > From: Erez Shitrit <erezsh@xxxxxxxxxxxx>
> >
> > If from some reason the SM responses to path query request with response
> > that doesn't contain the exact SGID, ipoib should warn and change that
> > part of the response before push it to the path record DB.
> > Otherwise, new record will be added to the path record DB with no access
> > to them from the ipoib.
> >
> > Demonstration of the bug is as the follow:
>
> this series contains bunch of fixes, any reason to direct them to
> -next (4.16) and not -rc (4.15)

Doug didn't send his pull request yet and most probably we will have two
pull requests in this merge window, one with already accepted code and
another with fixes from Denny and us. So all these patches are targeted
for 4.15.


>
> Also, in most of the cases ppl didn't provide a Fixes: line with the
> offending patch, any reason to skip that?

There are two main reasons:
1. I didn't request to add Fixes for refactoring code (most Parav's
patches), because I don't want that code to be picked for stable@ trees
by Greg's and Sasha's automatic scripts.
2. Sometimes, it is not clear the origin of the bug and the chances to
have wrong Fixes are higher than to have right ones.

Everything else is my mistake during review. Can you point me to
specific commits where you would like to see Fixes with right Fixes? I'll add.

Thanks

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux