On Tue, Nov 14, 2017 at 11:23:07PM +0200, Or Gerlitz wrote:
> > +
> > + if (rdma_ib_or_roce(qp->device, port)) {
> > + if (attr_mask & IB_QP_RQ_PSN && attr->rq_psn & ~0xffffff) {
> > + pr_warn("%s: %s rq_psn overflow, masking to 24 bits\n",
> > + __func__, qp->device->name);
> > + attr->rq_psn &= 0xffffff;
> > + }
> > +
> > + if (attr_mask & IB_QP_SQ_PSN && attr->sq_psn & ~0xffffff) {
> > + pr_warn("%s: %s sq_psn overflow, masking to 24 bits\n",
> > + __func__, qp->device->name);
> > + attr->sq_psn &= 0xffffff;
> > + }
> > + }
> > +
>
> Isn't this what we tried to push in the past and Jason/Sean rejected [1]?
>
> [1] https://marc.info/?l=linux-rdma&m=142309249413868&w=2
No, this version is what I asked for originally in that thread:
I think we'd be better off keeping the current behavior of masking
the PSN, not enforcing the limit.
The issue was because the link'd version returned an error.
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
