On Tue, Nov 14, 2017 at 2:52 PM, Leon Romanovsky <leon@xxxxxxxxxx> wrote: > From: Parav Pandit <parav@xxxxxxxxxxxx> > > When path ah_attr initialization from path record > fails, ib_cm_send_rej() uses av.ah_attr fields to send out reject > message. In such cases initialization of path record software fields > is not needed. Code is simplified for same. is "Code is simplified for same" cut in the middle, I fail to understand the sentence. > Additionally in current code in cm_req_handler, when ib_get_cached_gid > fails for a given sgid_index of the GID of the GRH of the incoming CM MAD, > error code 12 is sent. This error code refers to primary GID in incoming > CM REQ and not for the GID in in MAD packet. > Therefore code is refactored to send code 5 (unsupported request) for such > error. You do two logical changes in one patch, doesn't seem right to me. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html