On 2017/11/14 17:11, Leon Romanovsky wrote: > On Tue, Nov 14, 2017 at 05:26:16PM +0800, Yixian Liu wrote: >> Considering the compatibility of supporting hip08's eq >> process and possible changes of data structure, this patch >> refactors the eq code structure of hip06. >> >> We move all the eq process code for hip06 from hns_roce_eq.c >> into hns_roce_hw_v1.c, and also for hns_roce_eq.h. With >> these changes, it will be convenient to add the eq support >> for later hardware version. >> >> Signed-off-by: Yixian Liu <liuyixian@xxxxxxxxxx> >> Reviewed-by: Lijun Ou <oulijun@xxxxxxxxxx> >> Reviewed-by: Wei Hu (Xavier) <xavier.huwei@xxxxxxxxxx> >> --- >> drivers/infiniband/hw/hns/Makefile | 2 +- >> drivers/infiniband/hw/hns/hns_roce_cmd.c | 1 + >> drivers/infiniband/hw/hns/hns_roce_cq.c | 19 +- >> drivers/infiniband/hw/hns/hns_roce_device.h | 57 ++- >> drivers/infiniband/hw/hns/hns_roce_eq.c | 759 ---------------------------- >> drivers/infiniband/hw/hns/hns_roce_eq.h | 134 ----- >> drivers/infiniband/hw/hns/hns_roce_hw_v1.c | 740 ++++++++++++++++++++++++++- >> drivers/infiniband/hw/hns/hns_roce_hw_v1.h | 44 +- >> drivers/infiniband/hw/hns/hns_roce_main.c | 16 +- >> drivers/infiniband/hw/hns/hns_roce_qp.c | 1 + >> 10 files changed, 843 insertions(+), 930 deletions(-) >> delete mode 100644 drivers/infiniband/hw/hns/hns_roce_eq.c >> delete mode 100644 drivers/infiniband/hw/hns/hns_roce_eq.h >> >> diff --git a/drivers/infiniband/hw/hns/Makefile b/drivers/infiniband/hw/hns/Makefile >> index ff426a6..97bf2cd 100644 >> --- a/drivers/infiniband/hw/hns/Makefile >> +++ b/drivers/infiniband/hw/hns/Makefile >> @@ -5,7 +5,7 @@ >> ccflags-y := -Idrivers/net/ethernet/hisilicon/hns3 >> >> obj-$(CONFIG_INFINIBAND_HNS) += hns-roce.o >> -hns-roce-objs := hns_roce_main.o hns_roce_cmd.o hns_roce_eq.o hns_roce_pd.o \ >> +hns-roce-objs := hns_roce_main.o hns_roce_cmd.o hns_roce_pd.o \ >> hns_roce_ah.o hns_roce_hem.o hns_roce_mr.o hns_roce_qp.o \ >> hns_roce_cq.o hns_roce_alloc.o >> obj-$(CONFIG_INFINIBAND_HNS_HIP06) += hns-roce-hw-v1.o >> diff --git a/drivers/infiniband/hw/hns/hns_roce_cmd.c b/drivers/infiniband/hw/hns/hns_roce_cmd.c >> index 1085cb2..9ebe839 100644 >> --- a/drivers/infiniband/hw/hns/hns_roce_cmd.c >> +++ b/drivers/infiniband/hw/hns/hns_roce_cmd.c >> @@ -103,6 +103,7 @@ void hns_roce_cmd_event(struct hns_roce_dev *hr_dev, u16 token, u8 status, >> context->out_param = out_param; >> complete(&context->done); >> } >> +EXPORT_SYMBOL_GPL(hns_roce_cmd_event); > > Are you sure that you need these symbols to be exported (used in other modules)? > > Thanks > Yes, this symbol has been used in asynchronous event handle to query the result of mailbox cmd execution. It is in a different module. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
