Re: [PATCH 2/2] iw_cxgb4: atomically flush the qp

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2017-11-09 at 07:21 -0800, Steve Wise wrote:
> __flush_qp() has a race condition where during the flush operation,
> the qp lock is released allowing another thread to possibly post a WR,
> which corrupts the queue state, possibly causing crashes.  The lock was
> released to preserve the cq/qp locking hierarchy of cq first, then qp.
> However releasing the qp lock is not necessary; both RQ and SQ CQ locks
> can be acquired first, followed by the qp lock, and then the RQ and SQ
> flushing can be done w/o unlocking.
> 
> Signed-off-by: Steve Wise <swise@xxxxxxxxxxxxxxxxxxxxx>

Thanks, applied.

-- 
Doug Ledford <dledford@xxxxxxxxxx>
    GPG KeyID: B826A3330E572FDD
    Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux