On Wed, 2017-10-25 at 18:56 +0300, Leon Romanovsky wrote: > From: Leon Romanovsky <leonro@xxxxxxxxxxxx> > > The RDMA/umem uses generic RB-trees macros to generate various ib_umem > access functions. The generation is performed with INTERVAL_TREE_DEFINE > macro, which allows one of two modes: declare all functions as static or > declare none of the function to be static. > > The second mode of operation produces the following sparse errors: > drivers/infiniband/core/umem_rbtree.c:69:1: > warning: symbol 'rbt_ib_umem_iter_first' was not declared. > Should it be static? > drivers/infiniband/core/umem_rbtree.c:69:1: > warning: symbol 'rbt_ib_umem_iter_next' was not declared. > Should it be static? > > Code relocation together with declaration of such functions to be > "static" solves the issue. > > Because there is no need to have separate file for two functions, > let's consolidate umem_rtree.c and umem_odp.c into one file. > > Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxxxx> Thanks, applied. -- Doug Ledford <dledford@xxxxxxxxxx> GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
Attachment:
signature.asc
Description: This is a digitally signed message part