Re: [PATCH v1 rdma-core 1/2] bnxt_re/lib: fix the memory barrier call during poll-cq

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Nov 10, 2017 at 05:01:42PM +0530, Devesh Sharma wrote:

> > And the the kernel version of this should be using READ_ONCE()
> 
> Okay, we will fix this in our driver. So, READ_ONCE(CQE.valid) should
> be enough right?

Yes, I think so.

> > In user space we should probably create a
> >
> >  udma_from_device_read_once(x)
> >
> > That incorporates the barrier and the 'access_once' semantics..
> 
> Do you want us to pull all the defined in kernel space compiler.h
> verbitum to rdma-core

No.. kernel is using a quite different approach. We would want to use
C11 atomic_read in user space for most architectures.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux