On Wed, Nov 08, 2017 at 06:27:26AM +0000, Parav Pandit wrote:
>
>
> > +static bool bnxt_re_is_vlan_pkt(struct bnxt_qplib_cqe *orig_cqe,
> > + u16 *vid, u8 *sl)
> > +{
> > + u32 metadata;
> > + u16 tpid;
> > + bool ret = false;
> > +
> Large number of places reverse Christmas tree reverse order is not followed, but let's try to follow for newly added code like below.
> bool ret = false;
> u32 metadata;
> u16 tpid;
Reversed Christmas tree is a netdev requirement and not other subsystems,
so it a little bit too much to request from the people to do it without
actual updating CodingStyle guide.
I personally require it in our internal reviews to ensure that every
patch can go through netdev if needed (for example shared code) and not
because I like it.
Thanks
Attachment:
signature.asc
Description: PGP signature
