Re: [PATCH rdma-core] librdmacm: Store error code from getaddrinfo in errno

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 07, 2017 at 11:50:38AM +0200, Yuval Shaia wrote:
> +++ b/librdmacm/addrinfo.c
> @@ -227,7 +227,7 @@ static int ucma_getaddrinfo(const char *node, const char *service,
>  		ret = getaddrinfo(node, service, NULL, &ai);
>  	}
>  	if (ret)
> -		return ret;
> +		return ERR(ret);

No, you cannot assign the return value from getaddrinfo directly errno, they
are not the same number space.

> diff --git a/librdmacm/examples/cmatose.c b/librdmacm/examples/cmatose.c
> index b1c9dd13..625849ce 100644
> +++ b/librdmacm/examples/cmatose.c
> @@ -507,7 +507,7 @@ static int run_server(void)
>  
>  	ret = get_rdma_addr(src_addr, dst_addr, port, &hints, &test.rai);
>  	if (ret) {
> -		printf("cmatose: getrdmaaddr error: %s\n", gai_strerror(ret));
> +		printf("cmatose: getrdmaaddr error: %s\n", gai_strerror(errno));

Also nope, gai_strerror does not process errnos.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux