On Tue, Nov 07, 2017 at 08:30:22AM -0600, Gustavo A. R. Silva wrote: > Hi Leon, > > Quoting Leon Romanovsky <leon@xxxxxxxxxx>: > > > On Mon, Nov 06, 2017 at 08:35:14AM -0600, Gustavo A. R. Silva wrote: > > > Check on return value and goto label mbx_err are unnecessary. > > > > > > Addresses-Coverity-ID: 1268780 > > > Signed-off-by: Gustavo A. R. Silva <garsilva@xxxxxxxxxxxxxx> > > > --- > > > drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 4 +--- > > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > > > diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c > > > b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c > > > index f8c14c7..db02bbb 100644 > > > --- a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c > > > +++ b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c > > > @@ -1956,9 +1956,7 @@ int ocrdma_mbx_dealloc_lkey(struct ocrdma_dev > > > *dev, int fr_mr, u32 lkey) > > > cmd->lkey = lkey; > > > cmd->rsvd_frmr = fr_mr ? 1 : 0; > > > status = ocrdma_mbx_cmd(dev, (struct ocrdma_mqe *)cmd); > > > - if (status) > > > - goto mbx_err; > > > -mbx_err: > > > + > > > > Can you please remove assignment from "int status = -ENOMEM"? > > It produces warning too. > > > > OK. Will do. > > By the way, which compiler triggers that warning? Honestly, I don't remember, one of my building bots complained about it. Thanks > > I'm using GCC 7.2.0 and I don't see it. > > Thanks > -- > Gustavo A. R. Silva > > > > >
Attachment:
signature.asc
Description: PGP signature
