On Sun, Nov 05, 2017 at 09:10:29AM +0200, Leon Romanovsky wrote: > > @@ -909,6 +909,15 @@ enum ibv_qp_attr_mask { > > IBV_QP_PATH_MIG_STATE = 1 << 18, > > IBV_QP_CAP = 1 << 19, > > IBV_QP_DEST_QPN = 1 << 20, > > +#if 0 > > + /* These bits were supported on older kernels, but never exposed to > > + * user space: > > + */ > > + _IBV_QP_COMPAT1 = 1 << 21, > > + _IBV_QP_COMPAT2 = 1 << 22, > > + _IBV_QP_COMPAT3 = 1 << 23, > > + _IBV_QP_COMPAT3 = 1 << 24, > > +#endif > > Why do we need "if 0" in production code (global header file)? It is really a comment. I don't want to introduce new global symbols just for this, or loose the obvious formatting structure of the enum. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html