On Thu, Nov 02, 2017 at 08:29:32PM +0200, Leon Romanovsky wrote: > On Thu, Nov 02, 2017 at 11:23:25AM -0700, Bryan Tan wrote: > > On Thu, Nov 02, 2017 at 08:02:47PM +0200, Leon Romanovsky wrote: > > > > Here we assumed that the verbs layer will only call down to us to > > > > destroy a valid SRQ. If an SRQ has been created, then the srq_tbl > > > > should exist. I can add a check here if that's not behaviour we > > > > should rely on. > > > > > > By saying "verbs layer", are you referring to libibverbs or IB/core? > > > > > > > IB/core. Looking at core/verbs.c, it seems like the parameters are > > assumed to be good. I'm unclear on who is responsible for ensuring > > or checking for good inputs, kernel clients, IB/core, or the driver. > > The first one who can recognize the wrong parameters - fail early. > So if IB/core provides to you clean input, there is no need to check it > again. > I'll add the check then, given that IB/core doesn't make any guarantees. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
