> Subject: [PATCH v2 4/8] IB/srpt: Change default behavior from using SRQ to > using RC > Bart, this last of the 4 target patches causes our internal SRP testing to fail. > From the IB spec: > > C9-150.2.1: For QPs that are not associated with an SRQ, each HCA > receive queue shall generate end-to-end flow control credits. If > a QP is associated with an SRQ, the HCA receive queue shall not > generate end-to-end flow control credits. > I'm looking at why but... > Add new configfs attributes that allow to configure which mode to use > (/sys/kernel/config/target/srpt/$GUID/$GUID/attrib/use_srq). Note: > only the attribute for port 1 is relevant on multi-port adapters. > It looks like the above work around cannot work. The use_srq is tested and the SRQ is allocated when the device is added. Setting a target relative attribute is too late in the sequence to enable the old SRQ usage. I hardwired the SRQ creation in srpt_add_one() to verify it works. I suspect you may want to unconditionally create the SRQ and change the usage at login time based on the target flag? Mike -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
